IDocument 2 For Mac - 103 User Reviews

12/28/2021by admin
Mac
  1. IDocument 2 For Mac - 103 User Reviews
  2. IDocument 2 For Mac - 103 User Reviews 2017
  • Show Reviews FROM CNET iPhone 13; 4th stimulus check status; Best VPN service of 2021; The best Wi-Fi routers for 2021.
  • Roku Streaming Stick Review: A $50 Wonder and Your TV's New Best Pal. If you're a hard-line iOS user with no need for MicroUSB.

Z02P 2 1/2” GAMMA STRAPS N12 4 #10 LOCKWASHER PL4 1 1-1/2” PLASTIC CAP - BLACK PL4R 1 1-1/2” PLASTIC CAP – RED 1 INSTRUCTION SHEET 1 WARRANTY SHEET/SAFETY SHEET 1 TIP SHEET Please note: In an effort to keep the price on Maco Antennas down, we have decided not to clean up all.

User

Issue1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed)

IDocument 2 For Mac - 103 User Reviews

Description

Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Provider.When the user presses Ctrl-K or Ctrl-E:Transition the user into keyword mode using their default search provider. Pressing Ctrl-K will give the omnibox focus, and will display 'Search Google:' on the left. If the user has already entered text into the omnibox and presses Ctrl-K, their text will be preserved, but they will be transitioned into keyword mode anyway. If the user is already in keyword mode (even if it's with a non-default search provider), the text they have entered will become selected. Upon pressing backspace, they will be left with an empty omnibox.When the user types '?' into the omnibox:If the user types or pastes a '?' at the beginning of their (possibly empty) input text, transition them into keyword mode with their default search provider. Upon pressing backspace, the omnibox will be left '?' (and their input).Remove forced queries. We should be able to search for '?' directly.BUG=267629, 592540Committed: https://crrev.com/00687d006b3b838d1274f52a2dee455ce988d2fdCr-Commit-Position: refs/heads/[email protected]{#398580}

Patch Set 1 #

Patch Set 2 : Added method stubs in omnibox_edit_unittest.cc #

Patch Set 3 : Changed MOCK_METHOD0 to MOCK_METHOD1 in autocomplete_text_field_unittest_helper.h #

Patch Set 4 : Removed complex last_keystroke_was_question_mark logic, modified browsertest for focus search to re… #

Patch Set 5 : Reverted autocomplete_text_field* #

Patch Set 6 : Removed forced queries using '?'. Removed Ctrl-K preserving the user's keyword if they're already … #

Total comments: 29

Patch Set 7 : Refactored #

Patch Set 8 : Fixed a unit test compilation #

Patch Set 9 : Fixed compilation on Mac and removed forced query unit tests #

Patch Set 10 : Refactored #

Patch Set 11 : Remove calls to InternalSetUserText #

Patch Set 12 : Fixed unit test compilation #

Total comments: 18

Patch Set 13 : Fix nits #

Patch Set 14 : Rebase, make '?' enter keyword mode on nonempty inputs #

Patch Set 15 : Remove SetCaretPos #

Patch Set 16 : Moved ? browser test to interactive ui test #

Total comments: 2

Patch Set 17 : Deprecated forced query in omnibox_input_type.proto #

Patch Set 18 : Add case for deprecated forced query #

Patch Set 19 : Removed call to StartAutocomplete and move caret to beginning when typing ? #

Patch Set 20 : Really removed call to UpdatePopup #

Patch Set 21 : Factor out some code into OmniboxView and fix nits #

Total comments: 14

Patch Set 22 : Refactor State stuff #

Patch Set 23 : Fix unit test compilation #

Patch Set 24 : Fix bug in OmniboxView::GetStateChanges #

Patch Set 25 : Moved OmniboxViewStateChanges into OmniboxView::StateChanges #

Patch Set 26 : Added includes for omnibox_edit_model.h #

Patch Set 27 : Add SkColor include #

Patch Set 28 : Add includes for mac tests #

Download [raw][tar.bz2]
Unified diffsSide-by-side diffsDelta from patch setStats (+424 lines, -397 lines)Patch
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 4 chunks+106 lines, -37 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 4 chunks+0 lines, -95 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk+1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm View 1 chunk+1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h View 3 chunks+3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 6 chunks+16 lines, -41 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_browsertest.mm View 1 chunk+1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc View 1 chunk+1 line, -1 line 0 comments Download
M chrome/browser/ui/location_bar/location_bar.h View 1 chunk+1 line, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk+22 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk+1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 1 chunk+1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 1 chunk+1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk+1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 chunk+1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 2 chunks+2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 4 chunks+20 lines, -31 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk+1 line, -1 line 0 comments Download
M components/metrics/proto/omnibox_input_type.proto View 1 chunk+2 lines, -2 lines 0 comments Download
M components/omnibox/browser/autocomplete_input.h View 1 chunk+0 lines, -6 lines 0 comments Download
M components/omnibox/browser/autocomplete_input.cc View 4 chunks+2 lines, -32 lines 0 comments Download
M components/omnibox/browser/autocomplete_input_unittest.cc View 2 chunks+14 lines, -11 lines 0 comments Download
M components/omnibox/browser/autocomplete_provider.h View 1 chunk+0 lines, -8 lines 0 comments Download
M components/omnibox/browser/autocomplete_result.cc View 1 chunk+1 line, -4 lines 0 comments Download
M components/omnibox/browser/base_search_provider.cc View 1 chunk+0 lines, -5 lines 0 comments Download
M components/omnibox/browser/bookmark_provider.cc View 1 chunk+1 line, -2 lines 0 comments Download
M components/omnibox/browser/builtin_provider.cc View 1 chunk+0 lines, -1 line 0 comments Download
M components/omnibox/browser/history_quick_provider.cc View 1 chunk+2 lines, -3 lines 0 comments Download
M components/omnibox/browser/history_url_provider.cc View 1 chunk+1 line, -2 lines 0 comments Download
M components/omnibox/browser/keyword_provider.cc View 1 chunk+1 line, -2 lines 0 comments Download
M components/omnibox/browser/omnibox_edit_model.h View 7 chunks+26 lines, -18 lines 0 comments Download
M components/omnibox/browser/omnibox_edit_model.cc View 15 chunks+109 lines, -48 lines 0 comments Download
M components/omnibox/browser/omnibox_edit_unittest.cc View 2 chunks+6 lines, -3 lines 0 comments Download
M components/omnibox/browser/omnibox_view.h View 5 chunks+36 lines, -9 lines 0 comments Download
M components/omnibox/browser/omnibox_view.cc View 2 chunks+42 lines, -0 lines 0 comments Download
M components/omnibox/browser/search_provider.cc View 3 chunks+0 lines, -13 lines 0 comments Download
M components/omnibox/browser/search_suggestion_parser.cc View 2 chunks+1 line, -4 lines 0 comments Download
M components/omnibox/browser/shortcuts_provider.cc View 1 chunk+0 lines, -1 line 0 comments Download
M components/search_engines/template_url_unittest.cc View 1 chunk+0 lines, -4 lines 0 comments Download

Messages

Total messages: 191 (79 generated)
Expand Messages Collapse Messages Show Generated Messages Hide Generated Messages
Tom (Use chromium acct)
[email protected] changed reviewers: + [email protected]
4 years, 8 months ago (2016-04-04 22:49:50 UTC) #1
Tom (Use chromium acct) 4 years, 8 months ago (2016-04-04 22:49:51 UTC) #2
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-04 22:50:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/1
4 years, 8 months ago (2016-04-04 22:51:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-04 23:03:33 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/195634)
4 years, 8 months ago (2016-04-04 23:03:34 UTC) #6
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-04 23:19:43 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/20001
4 years, 8 months ago (2016-04-04 23:20:15 UTC) #8
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-04 23:52:50 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/40001
4 years, 8 months ago (2016-04-04 23:53:02 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-05 00:05:13 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/45421) linux_android_rel_ng on ...
4 years, 8 months ago (2016-04-05 00:05:14 UTC) #12
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-05 00:39:48 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/40001
4 years, 8 months ago (2016-04-05 00:40:08 UTC) #14
Tom (Use chromium acct)
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-05 01:31:49 UTC) #15
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-05 01:32:04 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/40001
4 years, 8 months ago (2016-04-05 01:32:48 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-05 01:48:19 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/206833)
4 years, 8 months ago (2016-04-05 01:48:20 UTC) #19
Peter Kasting
Can you write up on the CL description the various behaviors this implements, including e.g. ...
4 years, 8 months ago (2016-04-05 01:49:32 UTC) #20
Peter Kasting
Also, the test failure here is real, so you'll want to fix that.
4 years, 8 months ago (2016-04-05 01:50:21 UTC) #21
Tom Anderson
Description was changed fromInterpret '?' and Ctrl-K or Ctrl-E as putting omnibox in ...
4 years, 8 months ago (2016-04-05 04:28:55 UTC) #22
Tom Anderson
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-05 04:31:40 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/40001
4 years, 8 months ago (2016-04-05 04:32:14 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-05 05:16:13 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/191144) linux_chromium_rel_ng on ...
4 years, 8 months ago (2016-04-05 05:16:14 UTC) #26
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-05 22:14:46 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/60001
4 years, 8 months ago (2016-04-05 22:15:40 UTC) #28
Tom (Use chromium acct)
Description was changed fromInterpret '?' and Ctrl-K or Ctrl-E as putting omnibox in ...
4 years, 8 months ago (2016-04-05 22:26:50 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-05 23:03:58 UTC) #30
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/191701)
4 years, 8 months ago (2016-04-05 23:03:59 UTC) #31
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-07 16:52:24 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/80001
4 years, 8 months ago (2016-04-07 16:52:41 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-07 17:46:09 UTC) #34
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 17:46:10 UTC) #35
Tom (Use chromium acct)
- Cleaned up some complex logic - Changed issue description - Fixed test failure
4 years, 8 months ago (2016-04-07 17:57:25 UTC) #36
Peter Kasting
'If the user is already in keyword mode (even if it's with a non-default search ...
4 years, 8 months ago (2016-04-08 00:12:42 UTC) #37
Peter Kasting
If I type '?', hit backspace to get the question mark back, and then type ...
4 years, 8 months ago (2016-04-08 00:22:31 UTC) #38
Peter Kasting
https://codereview.chromium.org/1855423003/diff/80001/chrome/browser/autocomplete/autocomplete_browsertest.cc File chrome/browser/autocomplete/autocomplete_browsertest.cc (right): https://codereview.chromium.org/1855423003/diff/80001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode202 chrome/browser/autocomplete/autocomplete_browsertest.cc:202: Nit: Don't add these https://codereview.chromium.org/1855423003/diff/80001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode218 chrome/browser/autocomplete/autocomplete_browsertest.cc:218: base::string16 dsp = ...
4 years, 8 months ago (2016-04-08 00:39:56 UTC) #39
Tom (Use chromium acct)
On 2016/04/08 00:12:42, Peter Kasting wrote: > 'If the user is already in keyword mode ...
4 years, 8 months ago (2016-04-08 01:13:55 UTC) #40
Peter Kasting
On 2016/04/08 01:13:55, Tom Anderson wrote: > On 2016/04/08 00:12:42, Peter Kasting wrote: > > ...
4 years, 8 months ago (2016-04-08 01:16:15 UTC) #41
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-12 20:02:35 UTC) #42
Tom (Use chromium acct)
https://codereview.chromium.org/1855423003/diff/80001/chrome/browser/autocomplete/autocomplete_browsertest.cc File chrome/browser/autocomplete/autocomplete_browsertest.cc (right): https://codereview.chromium.org/1855423003/diff/80001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode202 chrome/browser/autocomplete/autocomplete_browsertest.cc:202: On 2016/04/08 00:39:56, Peter Kasting wrote: > Nit: Don't ...
4 years, 8 months ago (2016-04-12 20:03:05 UTC) #43
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/100001
4 years, 8 months ago (2016-04-12 20:03:16 UTC) #44
Peter Kasting
https://codereview.chromium.org/1855423003/diff/80001/chrome/browser/autocomplete/autocomplete_browsertest.cc File chrome/browser/autocomplete/autocomplete_browsertest.cc (right): https://codereview.chromium.org/1855423003/diff/80001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode354 chrome/browser/autocomplete/autocomplete_browsertest.cc:354: omnibox_model->ClearKeyword(); On 2016/04/12 20:03:04, Tom Anderson wrote: > On ...
4 years, 8 months ago (2016-04-12 20:04:13 UTC) #45
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-12 20:37:53 UTC) #46
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/153435) mac_chromium_rel_ng on ...
4 years, 8 months ago (2016-04-12 20:37:54 UTC) #47
Peter Kasting
https://codereview.chromium.org/1855423003/diff/80001/components/omnibox/browser/omnibox_edit_model.h File components/omnibox/browser/omnibox_edit_model.h (right): https://codereview.chromium.org/1855423003/diff/80001/components/omnibox/browser/omnibox_edit_model.h#newcode39 components/omnibox/browser/omnibox_edit_model.h:39: enum EnteredKeywordModeMethod { On 2016/04/08 00:39:56, Peter Kasting wrote: ...
4 years, 8 months ago (2016-04-13 02:52:17 UTC) #48
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-13 23:37:31 UTC) #49
Tom (Use chromium acct)
https://codereview.chromium.org/1855423003/diff/80001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/80001/components/omnibox/browser/omnibox_edit_model.cc#newcode962 components/omnibox/browser/omnibox_edit_model.cc:962: view_->OnBeforePossibleChange(); On 2016/04/08 00:39:56, Peter Kasting wrote: > This ...
4 years, 8 months ago (2016-04-13 23:37:41 UTC) #50
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/120001
4 years, 8 months ago (2016-04-13 23:38:11 UTC) #51
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-13 23:50:58 UTC) #52
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/200773)
4 years, 8 months ago (2016-04-13 23:51:00 UTC) #53
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-14 00:44:38 UTC) #54
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/140001
4 years, 8 months ago (2016-04-14 00:45:07 UTC) #55
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-14 00:57:25 UTC) #56
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/210943)
4 years, 8 months ago (2016-04-14 00:57:26 UTC) #57
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-14 16:58:49 UTC) #58
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/160001
4 years, 8 months ago (2016-04-14 16:59:19 UTC) #59
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-14 17:44:23 UTC) #60
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 17:44:24 UTC) #61
Peter Kasting
https://codereview.chromium.org/1855423003/diff/100001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/100001/components/omnibox/browser/omnibox_edit_model.cc#newcode337 components/omnibox/browser/omnibox_edit_model.cc:337: user_text_base::ASCIIToUTF16('?')) { On 2016/04/13 23:37:40, Tom Anderson ...
4 years, 8 months ago (2016-04-15 00:58:55 UTC) #62
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 8 months ago (2016-04-15 05:20:45 UTC) #63
Tom (Use chromium acct)
https://codereview.chromium.org/1855423003/diff/160001/chrome/browser/autocomplete/autocomplete_browsertest.cc File chrome/browser/autocomplete/autocomplete_browsertest.cc (right): https://codereview.chromium.org/1855423003/diff/160001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode75 chrome/browser/autocomplete/autocomplete_browsertest.cc:75: void FocusSearchCheckPreconditions() { On 2016/04/15 00:58:55, Peter Kasting wrote: ...
4 years, 8 months ago (2016-04-15 05:20:52 UTC) #64
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/180001
4 years, 8 months ago (2016-04-15 05:20:53 UTC) #65
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 8 months ago (2016-04-15 07:07:42 UTC) #66
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 07:07:43 UTC) #67
Peter Kasting
https://codereview.chromium.org/1855423003/diff/160001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/160001/components/omnibox/browser/omnibox_edit_model.cc#newcode651 components/omnibox/browser/omnibox_edit_model.cc:651: view_->OnTemporaryTextMaybeChanged(user_text_, false, true); Calling InternalSetUserText() + OnTemporaryTextMaybeChanged() + StartAutocomplete() ...
4 years, 8 months ago (2016-04-15 20:32:48 UTC) #68
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-04-28 00:40:30 UTC) #69
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/200001
4 years, 7 months ago (2016-04-28 00:40:54 UTC) #70
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 7 months ago (2016-04-28 00:51:37 UTC) #71
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/208307)
4 years, 7 months ago (2016-04-28 00:51:39 UTC) #72
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-04-28 16:41:03 UTC) #73
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/220001
4 years, 7 months ago (2016-04-28 16:41:23 UTC) #74
Tom (Use chromium acct)
https://codereview.chromium.org/1855423003/diff/160001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/160001/components/omnibox/browser/omnibox_edit_model.cc#newcode651 components/omnibox/browser/omnibox_edit_model.cc:651: view_->OnTemporaryTextMaybeChanged(user_text_, false, true); On 2016/04/15 20:32:47, Peter Kasting wrote: ...
4 years, 7 months ago (2016-04-28 17:40:30 UTC) #75
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 7 months ago (2016-04-28 17:42:54 UTC) #76
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 17:42:56 UTC) #77
Peter Kasting
https://codereview.chromium.org/1855423003/diff/220001/chrome/browser/autocomplete/autocomplete_browsertest.cc File chrome/browser/autocomplete/autocomplete_browsertest.cc (right): https://codereview.chromium.org/1855423003/diff/220001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode255 chrome/browser/autocomplete/autocomplete_browsertest.cc:255: // Focus search when omnibox is _not_ alread in ...
4 years, 7 months ago (2016-04-28 21:24:41 UTC) #78
Tom (Use chromium acct)
Sorry for the sloppiness in ClearKeyword(), I feel the new code is a bit too ...
4 years, 7 months ago (2016-04-29 01:10:21 UTC) #79
Peter Kasting
https://codereview.chromium.org/1855423003/diff/220001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/220001/components/omnibox/browser/omnibox_edit_model.cc#newcode943 components/omnibox/browser/omnibox_edit_model.cc:943: AcceptTemporaryTextAsUserText(); On 2016/04/29 01:10:21, Tom Anderson wrote: > On ...
4 years, 7 months ago (2016-04-29 01:36:47 UTC) #80
Tom (Use chromium acct)
On 2016/04/29 01:36:47, Peter Kasting wrote: > https://codereview.chromium.org/1855423003/diff/220001/components/omnibox/browser/omnibox_edit_model.cc > File components/omnibox/browser/omnibox_edit_model.cc (right): > > https://codereview.chromium.org/1855423003/diff/220001/components/omnibox/browser/omnibox_edit_model.cc#newcode943 ...
4 years, 7 months ago (2016-05-02 23:55:20 UTC) #81
Peter Kasting
On 2016/05/02 23:55:20, Tom Anderson wrote: > On 2016/04/29 01:36:47, Peter Kasting wrote: > > ...
4 years, 7 months ago (2016-05-03 00:46:38 UTC) #82
Tom (Use chromium acct)
Description was changed fromInterpret '?' and Ctrl-K or Ctrl-E as putting omnibox in ...
4 years, 7 months ago (2016-05-18 23:28:43 UTC) #83
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-05-18 23:31:38 UTC) #84
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/260001
4 years, 7 months ago (2016-05-18 23:32:37 UTC) #85
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 7 months ago (2016-05-18 23:36:51 UTC) #86
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/8076) ios-device-gn on ...
4 years, 7 months ago (2016-05-18 23:36:53 UTC) #87
Tom (Use chromium acct)
Patchset #14 (id:260001) has been deleted
4 years, 7 months ago (2016-05-18 23:45:06 UTC) #88
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-05-18 23:45:19 UTC) #89
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/280001
4 years, 7 months ago (2016-05-18 23:45:53 UTC) #90
Tom (Use chromium acct)
Patchset #14 (id:280001) has been deleted
4 years, 7 months ago (2016-05-18 23:57:25 UTC) #91
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-05-18 23:57:36 UTC) #92
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/300001
4 years, 7 months ago (2016-05-18 23:58:07 UTC) #93
Tom (Use chromium acct)
Rebased on changes from https://codereview.chromium.org/1943683002/ https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc#newcode961 components/omnibox/browser/omnibox_edit_model.cc:961: StartAutocomplete(false, false, false); If ...
4 years, 7 months ago (2016-05-18 23:58:36 UTC) #94
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 7 months ago (2016-05-19 00:15:21 UTC) #95
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/68487)
4 years, 7 months ago (2016-05-19 00:15:22 UTC) #96
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-05-19 00:17:43 UTC) #97
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/320001
4 years, 7 months ago (2016-05-19 00:18:23 UTC) #98
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 7 months ago (2016-05-19 01:18:37 UTC) #99
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/113882)
4 years, 7 months ago (2016-05-19 01:18:39 UTC) #100
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-05-19 18:48:00 UTC) #101
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/340001
4 years, 7 months ago (2016-05-19 18:48:32 UTC) #102
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 7 months ago (2016-05-19 20:49:00 UTC) #103
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 20:49:02 UTC) #104
Mark P
[email protected] changed reviewers: + [email protected]
4 years, 7 months ago (2016-05-19 23:27:05 UTC) #105
Mark P
not lgtm (happened to be reading old snippets and saw a link to this changelist ...
4 years, 7 months ago (2016-05-19 23:27:07 UTC) #106
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-05-19 23:34:15 UTC) #107
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/360001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/360001
4 years, 7 months ago (2016-05-19 23:34:57 UTC) #108
Tom (Use chromium acct)
The CQ bit was unchecked by [email protected]
4 years, 7 months ago (2016-05-19 23:34:58 UTC) #109
Tom (Use chromium acct)
https://codereview.chromium.org/1855423003/diff/340001/components/metrics/proto/omnibox_input_type.proto File components/metrics/proto/omnibox_input_type.proto (left): https://codereview.chromium.org/1855423003/diff/340001/components/metrics/proto/omnibox_input_type.proto#oldcode38 components/metrics/proto/omnibox_input_type.proto:38: FORCED_QUERY = 5; On 2016/05/19 23:27:07, Mark P wrote: ...
4 years, 7 months ago (2016-05-20 00:32:46 UTC) #110
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-05-20 00:33:00 UTC) #111
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/360001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/360001
4 years, 7 months ago (2016-05-20 00:33:58 UTC) #112
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 7 months ago (2016-05-20 00:43:50 UTC) #113
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/8952) ios-simulator-gn on ...
4 years, 7 months ago (2016-05-20 00:43:52 UTC) #114
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 7 months ago (2016-05-20 00:49:05 UTC) #115
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/380001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/380001
4 years, 7 months ago (2016-05-20 00:49:32 UTC) #116
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 7 months ago (2016-05-20 03:05:49 UTC) #117
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/217092)
4 years, 7 months ago (2016-05-20 03:05:51 UTC) #118
Mark P
components/metrics/proto/omnibox_input_type.proto lgtm
4 years, 7 months ago (2016-05-20 04:40:12 UTC) #119
Mark P
Can you please file a bug to get the support pages updated? I think because ...
4 years, 7 months ago (2016-05-20 18:07:52 UTC) #120
Peter Kasting
https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc#newcode961 components/omnibox/browser/omnibox_edit_model.cc:961: StartAutocomplete(false, false, false); On 2016/05/18 23:58:36, Tom Anderson wrote: ...
4 years, 7 months ago (2016-05-21 00:01:01 UTC) #121
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-05-27 22:11:53 UTC) #122
Tom (Use chromium acct)
https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc#newcode961 components/omnibox/browser/omnibox_edit_model.cc:961: StartAutocomplete(false, false, false); On 2016/05/21 00:01:01, Peter Kasting wrote: ...
4 years, 6 months ago (2016-05-27 22:12:07 UTC) #123
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/400001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/400001
4 years, 6 months ago (2016-05-27 22:12:18 UTC) #124
Peter Kasting
https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc#newcode961 components/omnibox/browser/omnibox_edit_model.cc:961: StartAutocomplete(false, false, false); On 2016/05/27 22:12:07, Tom Anderson wrote: ...
4 years, 6 months ago (2016-05-27 22:24:04 UTC) #125
Tom (Use chromium acct)
https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc File components/omnibox/browser/omnibox_edit_model.cc (right): https://codereview.chromium.org/1855423003/diff/300001/components/omnibox/browser/omnibox_edit_model.cc#newcode961 components/omnibox/browser/omnibox_edit_model.cc:961: StartAutocomplete(false, false, false); On 2016/05/27 22:24:04, Peter Kasting wrote: ...
4 years, 6 months ago (2016-05-27 22:42:47 UTC) #126
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-05-27 23:05:15 UTC) #127
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/420001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855423003/420001
4 years, 6 months ago (2016-05-27 23:05:48 UTC) #128
Tom (Use chromium acct)
Made the change in OnAfterPossibleChange
4 years, 6 months ago (2016-05-27 23:05:49 UTC) #129
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-05-28 01:20:18 UTC) #130
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-28 01:20:21 UTC) #131
Peter Kasting
Nice. This is almost done. Congratulations on your patience and persistence on this change! https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc ...
4 years, 6 months ago (2016-06-01 01:07:27 UTC) #132
Tom (Use chromium acct)
Will update with the mac changes once Chrome finishes compiling on my laptop... https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc File ...
4 years, 6 months ago (2016-06-02 19:24:40 UTC) #133
Peter Kasting
https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc File chrome/browser/autocomplete/autocomplete_browsertest.cc (right): https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode335 chrome/browser/autocomplete/autocomplete_browsertest.cc:335: // they should be left with '?' in the ...
4 years, 6 months ago (2016-06-04 02:17:18 UTC) #134
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-06-04 17:49:30 UTC) #135
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/460001
4 years, 6 months ago (2016-06-04 17:49:43 UTC) #136
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-06-04 17:57:03 UTC) #137
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/16269)
4 years, 6 months ago (2016-06-04 17:57:06 UTC) #138
Tom (Use chromium acct)
Patchset #22 (id:460001) has been deleted
4 years, 6 months ago (2016-06-04 17:57:50 UTC) #139
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-06-04 17:58:14 UTC) #140
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/480001
4 years, 6 months ago (2016-06-04 17:58:24 UTC) #141
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-06-04 18:09:06 UTC) #142
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/239206)
4 years, 6 months ago (2016-06-04 18:09:08 UTC) #143
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-06-04 18:24:26 UTC) #144
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/500001
4 years, 6 months ago (2016-06-04 18:24:38 UTC) #145
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-06-04 18:57:17 UTC) #146
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/181077) linux_chromium_chromeos_rel_ng on ...
4 years, 6 months ago (2016-06-04 18:57:19 UTC) #147
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-06-04 19:50:20 UTC) #148
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/520001
4 years, 6 months ago (2016-06-04 19:50:37 UTC) #149
Tom (Use chromium acct)
https://codereview.chromium.org/1855423003/diff/440001/chrome/browser/ui/views/omnibox/omnibox_view_views.cc File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right): https://codereview.chromium.org/1855423003/diff/440001/chrome/browser/ui/views/omnibox/omnibox_view_views.cc#newcode528 chrome/browser/ui/views/omnibox/omnibox_view_views.cc:528: GetTextState(text_state_before_change_); On 2016/06/04 02:17:18, Peter Kasting wrote: > Seems ...
4 years, 6 months ago (2016-06-04 20:39:10 UTC) #150
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-06-04 20:50:32 UTC) #151
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-04 20:50:37 UTC) #152
Tom (Use chromium acct)
https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc File chrome/browser/autocomplete/autocomplete_browsertest.cc (right): https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode335 chrome/browser/autocomplete/autocomplete_browsertest.cc:335: // they should be left with '?' in the ...
4 years, 6 months ago (2016-06-04 22:20:48 UTC) #153
Peter Kasting
https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc File chrome/browser/autocomplete/autocomplete_browsertest.cc (right): https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode335 chrome/browser/autocomplete/autocomplete_browsertest.cc:335: // they should be left with '?' in the ...
4 years, 6 months ago (2016-06-05 01:20:27 UTC) #154
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-06-05 01:54:45 UTC) #155
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/540001
4 years, 6 months ago (2016-06-05 01:54:57 UTC) #156
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-06-05 02:06:40 UTC) #157
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/198539) mac_chromium_compile_dbg_ng on ...
4 years, 6 months ago (2016-06-05 02:06:43 UTC) #158
Tom (Use chromium acct)
On 2016/06/05 01:20:27, Peter Kasting wrote: > https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc > File chrome/browser/autocomplete/autocomplete_browsertest.cc (right): > > https://codereview.chromium.org/1855423003/diff/300001/chrome/browser/autocomplete/autocomplete_browsertest.cc#newcode335 ...
4 years, 6 months ago (2016-06-05 02:07:37 UTC) #159
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-06-05 02:39:09 UTC) #160
jannis.beyer22
[email protected] changed reviewers: + [email protected]
4 years, 6 months ago (2016-06-05 02:39:29 UTC) #161
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/560001
4 years, 6 months ago (2016-06-05 02:39:32 UTC) #162
jannis.beyer22 4 years, 6 months ago (2016-06-05 02:39:32 UTC) #163
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-06-05 02:50:58 UTC) #164
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/239228)
4 years, 6 months ago (2016-06-05 02:51:00 UTC) #165
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-06-06 16:49:49 UTC) #166
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/580001
4 years, 6 months ago (2016-06-06 16:50:19 UTC) #167
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-06-06 17:13:01 UTC) #168
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/122763)
4 years, 6 months ago (2016-06-06 17:13:04 UTC) #169
Peter Kasting
On 2016/06/05 02:07:37, Tom Anderson wrote: > On 2016/06/05 01:20:27, Peter Kasting wrote: > > ...
4 years, 6 months ago (2016-06-07 03:44:00 UTC) #170
Tom (Use chromium acct)
The CQ bit was checked by [email protected] to run a CQ dry run
4 years, 6 months ago (2016-06-07 23:52:53 UTC) #171
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/600001
4 years, 6 months ago (2016-06-07 23:53:29 UTC) #172
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-06-08 00:48:44 UTC) #173
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 00:48:46 UTC) #174
Tom (Use chromium acct)
The CQ bit was checked by [email protected]
4 years, 6 months ago (2016-06-08 00:57:46 UTC) #175
Tom (Use chromium acct)
The patchset sent to the CQ was uploaded after l-g-t-m from [email protected], [email protected] Link to ...
4 years, 6 months ago (2016-06-08 00:57:47 UTC) #176
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/600001
4 years, 6 months ago (2016-06-08 00:58:28 UTC) #177
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
4 years, 6 months ago (2016-06-08 01:07:44 UTC) #178
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/196755)
4 years, 6 months ago (2016-06-08 01:07:47 UTC) #179
Tom (Use chromium acct)
thomasanderson[email protected] changed reviewers: + [email protected]
4 years, 6 months ago (2016-06-08 01:15:30 UTC) #180
Tom (Use chromium acct)
+ [email protected] for OWNERS approval for chrome/test/base/ui_test_utils.cc
4 years, 6 months ago (2016-06-08 01:15:35 UTC) #181
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-08 14:56:02 UTC) #182
Tom (Use chromium acct)
The CQ bit was checked by [email protected]
4 years, 6 months ago (2016-06-08 15:55:57 UTC) #183
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855423003/600001
4 years, 6 months ago (2016-06-08 15:56:37 UTC) #184
commit-bot: I haz the power
Description was changed fromInterpret '?' and Ctrl-K or Ctrl-E as putting omnibox in ...
4 years, 6 months ago (2016-06-08 16:06:46 UTC) #185
commit-bot: I haz the power
Committed patchset #28 (id:600001)
4 years, 6 months ago (2016-06-08 16:06:50 UTC) #186
commit-bot: I haz the power
Description was changed fromInterpret '?' and Ctrl-K or Ctrl-E as putting omnibox in ...
4 years, 6 months ago (2016-06-08 16:08:31 UTC) #187
commit-bot: I haz the power
Patchset 28 (id:??) landed as https://crrev.com/00687d006b3b838d1274f52a2dee455ce988d2fd Cr-Commit-Position: refs/heads/[email protected]{#398580}
4 years, 6 months ago (2016-06-08 16:08:36 UTC) #188
Mark P
Nice work on this involved changelist. I'm not sure if you noticed what I mentioned ...
4 years, 6 months ago (2016-06-08 19:56:06 UTC) #189
Mark P
On Wed, Jun 8, 2016 at 12:56 PM, <[email protected]> wrote: > Nice work on this ...
4 years, 6 months ago (2016-06-13 18:09:13 UTC) #190
Tom (Use chromium acct)
On 2016/06/13 18:09:13, Mark P wrote: > On Wed, Jun 8, 2016 at 12:56 PM, ...
4 years, 6 months ago (2016-06-13 18:33:41 UTC) #191
Expand Messages Collapse Messages Show Generated Messages Hide Generated Messages

IDocument 2 For Mac - 103 User Reviews 2017

One star for one bug fix out of dozens!From CS6 Adobe introduced a range of bugs to torment book designers! The bug that is fixed at flaming last is the fatal error InDesign Must shut down if you dare to change the page size with anything locked on the page, but they have introduced an extra level to the main bug, as a book designer a mechanical is made by making the document the page width + page width + spine! the height is the height, to change the spine you add or take away from the default spine width, but whereas anything in the slug used to move randomly, the get around was to group the items, not bless their cotton socks they have made the App randomly move thing regardless of if they are grouped or not! This is a major BUG as far as book cover designers are concerned we have to change spines all the time, so this breaks every workflow out there, to have these bugs present for so long is a disgrace! But at least we do not have the fatal error now, instead if the folds are locked InDesign just moves them anyway - IDIOTS!
Solemn Tones Mjolnir Drums Free Download
Download XLine For Mac 3.0
Comments are closed.